Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Reset KUBERNETES env variables to ensure there's no Kube connection for unit test #379

Conversation

cardil
Copy link
Contributor

@cardil cardil commented Oct 23, 2024

Changes

  • 🐛 Reset KUBERNETES env variables to ensure there's no Kube connection for unit test

/kind bug

Fixes #378

@knative-prow knative-prow bot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 23, 2024
@knative-prow knative-prow bot requested review from dsimansk and rhuss October 23, 2024 11:22
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 23, 2024
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.52%. Comparing base (a6872a8) to head (2206804).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #379   +/-   ##
=======================================
  Coverage   66.52%   66.52%           
=======================================
  Files          48       48           
  Lines        1440     1440           
=======================================
  Hits          958      958           
  Misses        412      412           
  Partials       70       70           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dsimansk dsimansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2024
Copy link

knative-prow bot commented Oct 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 72533af into knative-extensions:main Oct 23, 2024
24 checks passed
@cardil cardil deleted the bugfix/nightly-release-unittest-fail branch October 23, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pkg/k8s.TestNewClients unit test fails in the Release job
2 participants