Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a composer.json to enable support for PIE #524

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

asgrim
Copy link
Contributor

@asgrim asgrim commented Sep 18, 2024

Adds support for PIE.

Once merged, a maintainer would need to add this repo's URL to https://packagist.org/packages/submit :)

More info/documentation can be read on: https://github.com/php/pie/blob/main/docs/extension-maintainers.md

@nikic nikic merged commit 4f92c02 into krakjoe:master Sep 18, 2024
25 checks passed
@nikic
Copy link
Collaborator

nikic commented Sep 18, 2024

Hm, I can't submit this on packagist under the krakjoe/ vendor name, and it doesn't look like @krakjoe has has been active recently.

Maybe it would make the most sense to call the composer package apcu/apcu?

@asgrim asgrim deleted the add-support-for-pie branch September 18, 2024 21:25
@asgrim
Copy link
Contributor Author

asgrim commented Sep 18, 2024

Hm, I can't submit this on packagist under the krakjoe/ vendor name, and it doesn't look like @krakjoe has has been active recently.

Maybe it would make the most sense to call the composer package apcu/apcu?

Seems reasonable! I can send a patch in tomorrow to update that.

@asgrim
Copy link
Contributor Author

asgrim commented Sep 20, 2024

FYI, works nicely, thank you!

$ bin/pie install --with-php-config=/home/james/workspace/oss/php-src-build/bin/php-config apcu/apcu:dev-master
This command may need elevated privileges, and may prompt you for your password.
You are running PHP 8.3.11
Target PHP installation: 7.4.33 ts, on Linux/OSX/etc x86_64 (from /home/james/workspace/oss/php-src-build/bin/php)
Found package: apcu/apcu:dev-master which provides ext-apcu
phpize complete.
Configure complete with options: --with-php-config=/home/james/workspace/oss/php-src-build/bin/php-config
Build complete: /tmp/pie_downloader_66edbfab24a857.38933562/krakjoe-apcu-12e92f8/modules/apcu.so
Install complete: /home/james/workspace/oss/php-src-build/lib/php/extensions/debug-zts-20190902/apcu.so
You must now add "extension=apcu" to your php.ini

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants