-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track2 sdk: Add cache module in azclient #7601
base: master
Are you sure you want to change the base?
Track2 sdk: Add cache module in azclient #7601
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the difference between these cache from https://github.com/kubernetes-sigs/cloud-provider-azure/blob/master/pkg/cache/azure_cache.go?
And how are you going to use azclient/cache to replace pkg/cache/azure_cache?
It is the same except that is is a module and it adopts golang generics. |
@MartinForReal so will you remove the pkg/cache/azure_cache.go? |
yes. but we can keep it until it is not used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for creating this PR. Since azclient is created as a separate module for more than just cloud-provider-azure, we can share the cache.
I will approve the PR but please confirm the following questions are not blockers to this PR.
My concerns:
- why we reinvent deepcopy?
- How are we going to protect the release of this module? we don't have e2e for this.
- when do we plan to onboard this module to cloud-provider-azure? asking this because I am working on vmss-cache etag change, and there's conflicts.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mainred, MartinForReal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Track2 sdk: Add cache module in azclient
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: