Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker: detect ip6tables setup failure and fallback to ipv4 only #3749

Merged
merged 1 commit into from
Oct 7, 2024
Merged

docker: detect ip6tables setup failure and fallback to ipv4 only #3749

merged 1 commit into from
Oct 7, 2024

Conversation

BenTheElder
Copy link
Member

/assign @aojea
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 4, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the area/provider/docker Issues or PRs related to docker label Oct 4, 2024
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2024
@BenTheElder
Copy link
Member Author

see: #3677, #3748, ...

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 4, 2024
@BenTheElder BenTheElder changed the title detect ip6tables setup failure and fallback to ipv4 only docker: detect ip6tables setup failure and fallback to ipv4 only Oct 4, 2024
@stmcginnis
Copy link
Contributor

/lgtm

It's a workaround, but seems like a common enough issue now that it's worth including.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 4, 2024
@aojea
Copy link
Contributor

aojea commented Oct 5, 2024

/lgtm

the jobs with vagrant are all failing, but does not seem related to this PR

/hold cancel

it stops the bleeding,

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 5, 2024
@BenTheElder BenTheElder merged commit b404897 into kubernetes-sigs:main Oct 7, 2024
24 of 29 checks passed
@BenTheElder
Copy link
Member Author

bypassed broken github actions that seem to be unrelated #3750

@BenTheElder BenTheElder deleted the ip6tables-missing branch October 7, 2024 16:43
@BenTheElder BenTheElder mentioned this pull request Oct 7, 2024
Closed
@BenTheElder BenTheElder mentioned this pull request Oct 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea Awaiting requested review from aojea

@neolit123 neolit123 Awaiting requested review from neolit123

Assignees

@stmcginnis stmcginnis

@aojea aojea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/docker Issues or PRs related to docker cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BenTheElder @k8s-ci-robot @stmcginnis @aojea