-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AppArmor recorder: add readdir support #2555
Conversation
Hi @mhils. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2555 +/- ##
==========================================
- Coverage 45.50% 41.28% -4.22%
==========================================
Files 79 109 +30
Lines 7782 18232 +10450
==========================================
+ Hits 3541 7527 +3986
- Misses 4099 10208 +6109
- Partials 142 497 +355 |
81aaf5a
to
79382be
Compare
@mhils I think the ebpf byteode needs to be regenerated. The verify step was failing. |
@mhils You need to run |
Layer 8 error 🙃 |
51194af
to
480dae9
Compare
480dae9
to
dbb6660
Compare
/ok-to-test |
@mhils If this doesn't pass could you please rebase it on main branch, we removed the image scanner for now because it seems that trivy rate limited their database image and is now causing a lot of timeout errors. |
Please rebase to fix the CI. |
dbb6660
to
5c2e012
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ccojocar, mhils, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR makes the AppArmor recorder properly detect
readdir
and emit a working profile.Which issue(s) this PR fixes:
None
Does this PR have test?
Yes.
Special notes for your reviewer:
Does this PR introduce a user-facing change?