Wait for kissattach to daemonize instead of sleeping. This also clean…

…s up the reaped process (defunct).

kissattach.go

@@ -5,7 +5,6 @@ import (
 	krpty "github.com/kr/pty"
 	"os"
 	"os/exec"
-	"time"
 )
 
 func KissAttach(port string, mtu int) (pty *os.File, err error) {
@@ -14,8 +13,6 @@ func KissAttach(port string, mtu int) (pty *os.File, err error) {
 		return nil, err
 	}
 
-	time.Sleep(100 * time.Millisecond)
-
 	args := []string{tty.Name(), port, "-l"}
 	if mtu > 0 {
 		args = append(args, fmt.Sprintf("-m %d", mtu))
@@ -31,9 +28,11 @@ func KissAttach(port string, mtu int) (pty *os.File, err error) {
 		return nil, err
 	}
 
-	// Wait for kissattach to open tty
-	time.Sleep(2 * time.Second)
+	// Wait for kissattach to daemonize
+	if err = c.Wait(); err != nil {
+		pty.Close()
+		return nil, err
+	}
 
-	err = tty.Close()
-	return pty, err
+	return pty, tty.Close()
 }