fix(IDN): use INTL_IDNA_VARIANT_UTS46 for idn_* functions (#20)

* fix(IDN): use INTL_IDNA_VARIANT_UTS46 for idn_* functions * fix(IDN): use INTL_IDNA_VARIANT_UTS46 for idn_* functions
layershifter · Nov 18, 2017 · e570f7a · e570f7a
1 parent c27974a
commit e570f7a
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 0 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -23,6 +23,8 @@ env:
     - ENGINE=php VERSION=7.0 INTL=1
     - ENGINE=php VERSION=7.1 INTL=0
     - ENGINE=php VERSION=7.1 INTL=1
+    - ENGINE=php VERSION=7.2 INTL=0
+    - ENGINE=php VERSION=7.2 INTL=1
     - ENGINE=hhvm INTL=0
 
 before_script:

diff --git a/src/IDN.php b/src/IDN.php
@@ -38,6 +38,10 @@ public function toASCII($domain)
             return $this->transformer->encode($domain);
         }
 
+        if (defined('INTL_IDNA_VARIANT_UTS46')) {
+            return idn_to_ascii($domain, 0, INTL_IDNA_VARIANT_UTS46);
+        }
+
         return idn_to_ascii($domain);
     }
 
@@ -54,6 +58,10 @@ public function toUTF8($domain)
             return $this->transformer->decode($domain);
         }
 
+        if (defined('INTL_IDNA_VARIANT_UTS46')) {
+            return idn_to_utf8($domain, 0, INTL_IDNA_VARIANT_UTS46);
+        }
+
         return idn_to_utf8($domain);
     }
 }
diff --git a/travis/docker/php-7.2-intl/Dockerfile b/travis/docker/php-7.2-intl/Dockerfile
@@ -0,0 +1,7 @@
+FROM php:7.2-rc
+
+RUN apt-get update && apt-get install -y git zlib1g-dev libicu-dev g++
+RUN docker-php-ext-install intl
+RUN docker-php-ext-install zip
+
+RUN curl -sS https://getcomposer.org/installer | php -- --install-dir=/usr/bin/ --filename=composer
diff --git a/travis/docker/php-7.2/Dockerfile b/travis/docker/php-7.2/Dockerfile
@@ -0,0 +1,6 @@
+FROM php:7.2-rc
+
+RUN apt-get update && apt-get install -y git zlib1g-dev
+RUN docker-php-ext-install zip
+
+RUN curl -sS https://getcomposer.org/installer | php -- --install-dir=/usr/bin/ --filename=composer