Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: the findDefEqAbuse linter #19177

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

adomani
Copy link
Collaborator

@adomani adomani commented Nov 18, 2024

This is a prototype, as per this Zulip discussion


Open in Gitpod

@adomani adomani changed the title Adomani/find defeq linter test: the findDefeqAbuse linter Nov 18, 2024
@adomani adomani changed the title test: the findDefeqAbuse linter test: the findDefEqAbuse linter Nov 18, 2024
@github-actions github-actions bot added the large-import Automatically added label for PRs with a significant increase in transitive imports label Nov 18, 2024
Copy link

github-actions bot commented Nov 18, 2024

PR summary ebe5ea4cbb

Import changes exceeding 2%

% File
+20.00% Mathlib.Tactic.Linter

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Tactic.Linter 25 30 +5 (+20.00%)
Import changes for all files
Files Import difference
There are 4622 files with changed transitive imports taking up over 195736 characters: this is too many to display!
You can run scripts/import_trans_difference.sh all locally to see the whole output.

Declarations diff

+ Y
+ d
+ f
+ f_eq_g
+ findDefEqAbuseLinter
+ g

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
large-import Automatically added label for PRs with a significant increase in transitive imports
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant