Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CategoryTheory): split up a product into a binary product #19199

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dagurtomas
Copy link
Collaborator


This is used in #18497 to prove that light condensed modules satisfy countable AB4*

Open in Gitpod

Copy link

github-actions bot commented Nov 18, 2024

PR summary 6326a1a718

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.CategoryTheory.Limits.Shapes.PiProd 405

Declarations diff

+ Pi.binaryFanOfProp
+ Pi.binaryFanOfPropIsLimit
+ Pi.map_eq_prod_map
+ hasBinaryProduct_of_products

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@joelriou joelriou added the awaiting-author A reviewer has asked the author a question or requested changes label Nov 18, 2024
@dagurtomas dagurtomas removed the awaiting-author A reviewer has asked the author a question or requested changes label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-category-theory Category theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants