Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CategoryTheory): expand the API for AB axioms #19200

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

@github-actions github-actions bot added the large-import Automatically added label for PRs with a significant increase in transitive imports label Nov 18, 2024
Copy link

github-actions bot commented Nov 18, 2024

PR summary b9fa6a81f4

Import changes exceeding 2%

% File
+46.01% Mathlib.CategoryTheory.Abelian.GrothendieckAxioms

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.CategoryTheory.Abelian.GrothendieckAxioms 626 914 +288 (+46.01%)
Mathlib.Algebra.Category.Grp.AB5 1302 1305 +3 (+0.23%)
Mathlib.CategoryTheory.Limits.Shapes.Countable 566 567 +1 (+0.18%)
Mathlib.Topology.Category.LightProfinite.Basic 1468 1469 +1 (+0.07%)
Import changes for all files
Files Import difference
5 files Mathlib.Topology.Category.LightProfinite.Extend Mathlib.Topology.Category.LightProfinite.AsLimit Mathlib.CategoryTheory.Limits.Shapes.Countable Mathlib.Topology.Category.LightProfinite.Basic Mathlib.Topology.Category.LightProfinite.Sequence
1
Mathlib.Algebra.Category.Grp.AB5 3
Mathlib.CategoryTheory.Abelian.GrothendieckAxioms 288

Declarations diff

+ AB4Star.ofAB5Star
+ ABOfShape
+ ABOfShapeDiscreteFinite
+ ABOfShapeDiscreteOfABOfShapeFinsetDiscrete
+ ABOfShapeOfFinal
+ ABOfShapeOfPreservesMono
+ ABStarOfShape
+ ABStarOfShapeDiscreteFinite
+ ABStarOfShapeDiscreteOfABStarOfShapeFinsetDiscreteOp
+ ABStarOfShapeOfInitial
+ ABStarOfShapeOfPreservesEpi
+ CountableAB4
+ CountableAB4.ofABOfShapeNat
+ CountableAB4.ofABOfShapeNatAndFinite
+ CountableAB4.ofCountableAB5
+ CountableAB4Star
+ CountableAB4Star.ofABStarOfShapeNat
+ CountableAB4Star.ofABStarOfShapeNatAndFinite
+ CountableAB4Star.ofCountableAB5Star
+ HasCountableCoproducts
+ HasCountableProducts
+ instance (priority := 100) hasCountableCoproducts_of_hasCoproducts [HasCoproducts C] :
+ instance (priority := 100) hasCountableCoproducts_of_hasCountableColimits [HasCountableColimits C] :
+ instance (priority := 100) hasCountableProducts_of_hasCountableLimits [HasCountableLimits C] :
+ instance (priority := 100) hasCountableProducts_of_hasProducts [HasProducts C] :
+ instance (priority := 100) hasFiniteCoproducts_of_hasCountableCoproducts
+ instance (priority := 100) hasFiniteProducts_of_hasCountableProducts [HasCountableProducts C] :
+ instance [HasCoproducts C] [AB4 C] (J : Type v) : ABOfShape (Discrete J) C := inferInstance
+ instance [HasCountableCoproducts C] : HasCoproductsOfShape J C
+ instance [HasCountableProducts C] : HasProductsOfShape J C
+ liftToFinset
+ liftToFinsetEvaluationIso
+ liftToFinsetLimIso
+ liftToFinsetLimitCone
+ liftToFinsetObj
+ preservesFiniteColimitsLiftToFinset
+ sequentialFunctor_final
+ sequentialFunctor_final_aux
+ sequentialFunctor_initial
+ sequentialFunctor_initial_aux
++ sequentialFunctor
++ sequentialFunctor_map
++ sequentialFunctor_obj

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


Increase in tech debt: (relative, absolute) = (1.00, 0.00)
Current number Change Type
1554 1 erw

Current commit b9fa6a81f4
Reference commit bcef7c52e8

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@dagurtomas
Copy link
Collaborator Author

PR summary 2df551d9ea

Import changes exceeding 2%

% File
+46.01% Mathlib.CategoryTheory.Abelian.GrothendieckAxioms

Import changes for modified files

Declarations diff

Increase in tech debt: (relative, absolute) = (1.00, 0.00)

Since the GrothendieckAxioms file isn't much used, I think this is fine

@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) large-import Automatically added label for PRs with a significant increase in transitive imports
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants