Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated KTable Documentation #780

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

BabyElias
Copy link
Contributor

@BabyElias BabyElias commented Sep 15, 2024

Description

Updated KTable documentation to include more examples for custom column widths and use of slots.

Changelog

  • Description: Updated documentation for KTable
  • Products impact: None
  • Addresses:
  • Components: KTable
  • Breaking: No
  • Impacts a11y: No
  • Guidance:

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical and brittle code paths are covered by unit tests
  • The change is described in the changelog section above

Reviewer guidance

  • Is the code clean and well-commented?
  • Are there tests for this change?
  • Are all UI components LTR and RTL compliant (if applicable)?
  • Add other things to check for here

Comments

Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @BabyElias! The examples are clear and the explanation is concise but detailed enough to outline the different use cases. Nice work. I think the changelog needs to be updated before merge, but otherwise this looks good to me

@BabyElias
Copy link
Contributor Author

Updated Changelog @marcellamaki

@BabyElias
Copy link
Contributor Author

Hey @marcellamaki , All good with the PR?

@marcellamaki
Copy link
Member

yes! thank you @BabyElias!

@marcellamaki marcellamaki merged commit 9ec9dd3 into learningequality:develop Sep 24, 2024
8 checks passed
learning-equality-bot bot pushed a commit that referenced this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants