Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-#641-Updating the KDS icon with the brand new logo. #809

Conversation

RONAK-AI647
Copy link
Contributor

@RONAK-AI647 RONAK-AI647 commented Oct 29, 2024

The favicon is updated with the latest one.

Description

The favicon (the icon that appears in the browsers was not updated in the KDS. Here is an attempt made to update the logo of KDS with the brand new logo.)

NOTE: In the kolibri repository, I have seen tags and files like "html-favicon" ," 'favicon' where relevant references could be made but in KDS I struggled a got to get it.
Not sure about the FAVICON file which I could not the find in then whole repository. After much exploring I got the kolibri.ico file which I assume is responsible for the favicon.

Issue addressed

#641
Addresses PR#809

THIS IS GLIPMSE OF HOW THE KOLIBRI ICON BEFORE AND AFTER.

image

Changelog

  • Description: The kolibri.ico favicon was updated for new branding.
  • [] Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • [] Critical and brittle code paths are covered by unit tests
  • The change is described in the changelog section above

Reviewer guidance

  • Is the code clean and well-commented?
  • Are there tests for this change?
  • Are all UI components LTR and RTL compliant (if applicable)?
  • Add other things to check for here

Comments

The favicon of KDS is updated with the new icon,
@RONAK-AI647 RONAK-AI647 changed the title Issue-#641-Udating the KDS icon with the brand new logo. Issue-#641-Updating the KDS icon with the brand new logo. Oct 29, 2024
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual testing confirms that the favicon is now updated on the docs build!

@rtibbles
Copy link
Member

Thank you for your contribution @RONAK-AI647 - we appreciate your work here!

(One thing to note, I had to slightly edit the changelog section of your PR description, as an important template comment had been deleted - something to look out for next time!)

@rtibbles rtibbles merged commit 02d3d85 into learningequality:develop Oct 29, 2024
8 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants