Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix KCard area not taking available width #820

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

MisRob
Copy link
Member

@MisRob MisRob commented Nov 11, 2024

Description

Fixes the issue that @akolson discovered in Studio when cards didn't take the full available width.

Issue addressed

A bug discovered in learningequality/studio#4803

Before/after screenshots

Before After
Screenshot from 2024-11-11 21-08-15 Screenshot from 2024-11-11 21-07-28

Changelog

Steps to test

I linked to Studio.

Implementation notes

At a high level, how did you implement this?

Cause: Even though the wrapping <li> had the correct width, its child <div class="card-area" ...> didn't take the full width of its parent.

This PR fixes it by setting 100% width on the div.

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical and brittle code paths are covered by unit tests
  • The change is described in the changelog section above

Reviewer guidance

  • Is the code clean and well-commented?
  • Are there tests for this change?
  • Are all UI components LTR and RTL compliant (if applicable)?
  • Add other things to check for here

Comments

Note that the thumbnail overflow will be resolved in another PR.

@MisRob MisRob requested a review from akolson November 11, 2024 20:14
@MisRob MisRob added the TODO: needs review Waiting for review label Nov 11, 2024
Copy link
Member

@akolson akolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MisRob! This fixes the bug. The changes LGTM!

@akolson akolson merged commit f4ba97d into learningequality:develop Nov 11, 2024
8 checks passed
learning-equality-bot bot pushed a commit that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants