Fix KCard area not taking available width #820
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the issue that @akolson discovered in Studio when cards didn't take the full available width.
Issue addressed
A bug discovered in learningequality/studio#4803
Before/after screenshots
Changelog
KCard
Steps to test
I linked to Studio.
Implementation notes
At a high level, how did you implement this?
Cause: Even though the wrapping
<li>
had the correct width, its child<div class="card-area" ...>
didn't take the full width of its parent.This PR fixes it by setting
100%
width on thediv
.Testing checklist
Critical and brittle code paths are covered by unit testsReviewer guidance
Comments
Note that the thumbnail overflow will be resolved in another PR.