Skip to content

Commit

Permalink
linux: fix missing default packages in profiles.json
Browse files Browse the repository at this point in the history
Robert reported, that in firmware images generated by ASU, there is
`apk` package manager missing after the commit 44598c2 ("build:
remove broken dependency of metadata on toplevel .config variables").

That is happening, because apk got removed from `default_packages` list in
`profiles.json`, which is being generated by `json_overview_image_info` Make
target, which uses `scripts/json_overview_image_info.py` helper script,
which gets the information from `DEFAULT_PACKAGES` Make variable.

So lets fix it by providing `DEFAULT_PACKAGES` variable when its needed.

The reason why we didn't added those packages as a dependency to
base-files like any other packages, was to allow disabling them (in
order to save space).

Fixes: #16969
Fixes: openwrt/asu/issues/1084
Fixes: 44598c2 ("build: remove broken dependency of metadata on toplevel .config variables")
Reported-by: Robert Marko <robimarko@gmail.com>
Signed-off-by: Petr Štetiar <ynezz@true.cz>
Link: openwrt/openwrt#16986
Signed-off-by: Robert Marko <robimarko@gmail.com>
  • Loading branch information
ynezz authored and robimarko committed Nov 17, 2024
1 parent 40be892 commit 90f0be8
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions target/linux/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

include $(TOPDIR)/rules.mk
include $(INCLUDE_DIR)/target.mk
include $(INCLUDE_DIR)/default-packages.mk

export TARGET_BUILD=1

Expand Down

0 comments on commit 90f0be8

Please sign in to comment.