Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add missing docs for 0.7 #3203

Merged
merged 9 commits into from
Nov 12, 2024
Merged

chore: add missing docs for 0.7 #3203

merged 9 commits into from
Nov 12, 2024

Conversation

gbj
Copy link
Collaborator

@gbj gbj commented Nov 7, 2024

No description provided.

Copy link
Collaborator

@rakshith-ravi rakshith-ravi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit-pick, but I think it makes sense to include the rendering mode in the individual enums as well, since those are the ones that will be highlighted in LSPs when they're selected

router/src/ssr_mode.rs Outdated Show resolved Hide resolved
router/src/ssr_mode.rs Outdated Show resolved Hide resolved
router/src/ssr_mode.rs Outdated Show resolved Hide resolved
router/src/ssr_mode.rs Outdated Show resolved Hide resolved
router/src/ssr_mode.rs Outdated Show resolved Hide resolved
gbj and others added 7 commits November 11, 2024 17:36
Co-authored-by: Rakshith Ravi <rakshith.ravi@gmx.com>
Co-authored-by: Rakshith Ravi <rakshith.ravi@gmx.com>
Co-authored-by: Rakshith Ravi <rakshith.ravi@gmx.com>
Co-authored-by: Rakshith Ravi <rakshith.ravi@gmx.com>
Co-authored-by: Rakshith Ravi <rakshith.ravi@gmx.com>
@gbj gbj merged commit a5293f0 into main Nov 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants