Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor find or create Professor errors #11

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Refactor find or create Professor errors #11

merged 1 commit into from
Sep 1, 2023

Conversation

Eschults
Copy link
Member

@Eschults Eschults commented Sep 1, 2023

Follows up #10

@Eschults Eschults mentioned this pull request Sep 1, 2023
Merged
grmnlrt
grmnlrt approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@grmnlrt grmnlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

(At first I wanted to keep both approach as I don't trust the API, but this should work 👍 )

@grmnlrt grmnlrt merged commit f862cae into master Sep 1, 2023
1 check passed
@grmnlrt grmnlrt deleted the refactor-professor-errors branch September 1, 2023 08:31
@Eschults
Copy link
Member Author

Eschults commented Sep 1, 2023

Smart, hopefully the previous message won't raise again 🤞 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grmnlrt grmnlrt grmnlrt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Eschults @grmnlrt