Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a param tolerance of cut.py simple #1385

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

yunxinmengze
Copy link

No description provided.

@csukuangfj
Copy link
Contributor

csukuangfj commented Aug 9, 2024

This PR can be used to fix importing data files from kaldi.

For the yesno example,
Screenshot 2024-08-09 at 19 52 25

you can see from the above screenshot, we need a larger tolerance value, e.g., 0.1.


@yunxinmengze

Could you also fix
https://github.com/lhotse-speech/lhotse/blob/master/docs/kaldi.rst

We need to change

lhotse cut simple \
  -r ./data/train_manifests/recordings.jsonl.gz \
  -f ./data/train_manifests/features.jsonl.gz \
  -s ./data/train_manifests/supervisions.jsonl.gz \
  ./yesno_train.jsonl.gz

to

lhotse cut simple \
  -r ./data/train_manifests/recordings.jsonl.gz \
  -f ./data/train_manifests/features.jsonl.gz \
  -s ./data/train_manifests/supervisions.jsonl.gz \
  --tolerance 0.1 \
  ./yesno_train.jsonl.gz

@pzelasko
Copy link
Collaborator

Thanks! I'd be fine with setting the default tolerance to 0.1 if you want to make that change as well.

@pzelasko
Copy link
Collaborator

@yunxinmengze can you reformat the PR with black and commit again?

@pzelasko pzelasko added this to the v1.28.0 milestone Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants