New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix index creation and lookup logic #15527

Merged

LibretroAdmin merged 2 commits into libretro:master from JoeOsborn:db-indexing-fixes

Jul 27, 2023

Contributor

JoeOsborn commented Jul 27, 2023

This patch fixes some bugs and changes some behavior around RDB databases.

Behavior changes:

libretrodb_create_index now will not create an index if another index with the same name exists already.
Indexes can be created on keys for which not every item in the database has a value

Bug fixes:

Databases were open read-only before, so creating an index was a no-op
Item locations were bogus in the index
Item locations were written into the index in a bogus way (casting and order of operations on pointer math)
Binary search offsets were computed in a bogus way (same)

JoeOsborn added 2 commits

July 27, 2023 12:17


          Fix index creation and lookup logic

0c0682a


          fix c89 build

64a348e

LibretroAdmin merged commit 05b14ec into libretro:master

22 checks passed

GABO1423 mentioned this pull request

(UWP) Databases don't work anymore #15566

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet