Show also lightgun bind labels instead of only 'N/A' #15535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No idea if it would be an easy fix but a while ago I noticed that by default "Gun Trigger" is set to "Mouse 1" (which is great), but if you press Space to revert it to its default value it unbinds it instead 🤔 Not a big deal, just odd. |
|
Yep, I also wondered why bind reset only nulled it.. Since it is set after config creation, it must be looked at. And why not also default Mouse 2 to reload. Edit: Phew that was simple. |
sonninnos
force-pushed
the
lightgun-bind-label
branch
from
793cf85
to
8548db2
Compare
|
Nice! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently if a core does not have lightgun binds hooked up, all gun binds are shown as "N/A". Let's rather show "Gun Trigger (N/A)" instead etc.
Also accidentally noticed a weird related goof in the default keybinds.
Also added Mouse 2 as default reload button, and fixed mouse bind reset in general to default instead of null.