Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integer overscale GPU screenshot crash fixes #17118

Merged
merged 1 commit into from
Oct 26, 2024
Merged

Integer overscale GPU screenshot crash fixes #17118

merged 1 commit into from
Oct 26, 2024

Conversation

sonninnos
Copy link
Collaborator

Description

  • Made sure that all available video drivers on Windows use the same screen area and do not crash when taking GPU screenshots while integer overscale puts viewport outside of the visible screen
  • Fixed vulkan overscale image centering with RGUI to go along with the core image
  • Fixed d3d9 to do any kind of centering with integer overscale
  • Cleaned up some tabs

Hopefully someone can add the similar corrections to all other drivers if necessary.

Related Issues

Closes #6427

@LibretroAdmin LibretroAdmin merged commit c847b02 into libretro:master Oct 26, 2024
27 checks passed
@sonninnos sonninnos deleted the screenshot-integer-overscale branch October 26, 2024 13:51
@warmenhoven warmenhoven mentioned this pull request Oct 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Windows] GPU screenshot option broken using D3D
2 participants
@sonninnos @LibretroAdmin