Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] render-error-overlays #55

Merged
merged 2 commits into from
Jan 24, 2024
Merged

[feature] render-error-overlays #55

merged 2 commits into from
Jan 24, 2024

Conversation

lifeart
Copy link
Owner

@lifeart lifeart commented Jan 24, 2024

If some component rendering fails, we show error

Vite

image

Dev mode

image

Prod

image

Related links: vitejs/vite#2076

image

Copy link

netlify bot commented Jan 24, 2024

Deploy Preview for g-next ready!

Name Link
🔨 Latest commit dc9f47a
🔍 Latest deploy log https://app.netlify.com/sites/g-next/deploys/65b0b9aa5d9d03000861929f
😎 Deploy Preview https://deploy-preview-55--g-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lifeart lifeart marked this pull request as ready for review January 24, 2024 06:57
@lifeart lifeart mentioned this pull request Jan 24, 2024
80 tasks
Copy link

github-actions bot commented Jan 24, 2024

Code Coverage Report

Coverage after merging render-error-overlays into master

75.06%
Coverage Report
FileLines (%)Funcs (%)Uncovered Lines
.../pages/page-one
   Smile.ts79.596, 7, 8, 9, ...
.../pages/page-two
   Clock.ts94.2983.3318, 27
tests
   utils.ts95.6531, 75, 76, 77, ...
utils
   benchmark.ts69.4419, 20, 21, 22, ...
   compat.ts96.2328, 29, 30, 38, ...
   component.ts98.1673, 8, 9, 94, ...
   dom-api.ts12, 15, 21
   dom.ts99.2792.11641, 648, 667, 75, ...
   ember-inspector.ts14.70096, 97, 98, 99, ...
   if.ts57.2766.6796, 97, 98, 99, ...
   list.ts93.778576, 80, 81, 82, ...
   reactive.ts93.6866, 67, 85, 86, ...
   rehydration-dom-api.ts53.5796, 97, 98, 99, ...
   rehydration.ts135, 144
   runtime.ts95.7411, 12, 13
   shared.ts7492, 93, 94, 95, ...
   vm.ts24, 4, 56
utils/helpers
   hash.ts9066.6714, 15
   if.ts66.672, 3, 4
utils/inspector
   index.ts33.33096, 97, 98, 99, ...

Copy link

github-actions bot commented Jan 24, 2024

duration phase estimated regression +131ms [61ms to 202ms] OR +0.86% [0.4% to 1.33%]
renderEnd phase no difference [-2ms to 2ms]
render1000Items1End phase no difference [-1ms to 12ms]
clearItems1End phase no difference [-3ms to 2ms]
render1000Items2End phase estimated regression +1ms [0ms to 16ms] OR +0.15% [0.01% to 1.96%]
clearItems2End phase no difference [0ms to 0ms]
render5000Items1End phase estimated regression +23ms [5ms to 42ms] OR +0.6% [0.12% to 1.07%]
clearManyItems1End phase no difference [-7ms to 1ms]
render5000Items2End phase no difference [-17ms to 28ms]
clearManyItems2End phase no difference [-4ms to 7ms]
render1000Items3End phase no difference [-2ms to 9ms]
append1000Items1End phase no difference [-11ms to 22ms]
append1000Items2End phase no difference [-15ms to 18ms]
updateEvery10thItem1End phase no difference [-2ms to 16ms]
updateEvery10thItem2End phase no difference [-3ms to 0ms]
selectFirstRow1End phase no difference [-1ms to 0ms]
selectSecondRow1End phase no difference [0ms to 1ms]
removeFirstRow1End phase no difference [0ms to 5ms]
removeSecondRow1End phase no difference [0ms to 1ms]
swapRows1End phase no difference [0ms to 1ms]
swapRows2End phase no difference [0ms to 1ms]
clearItems4End phase no difference [-2ms to 4ms]
paint phase no difference [0ms to 0ms]

[09:09:21] Generating Benchmark Reports [started]
[09:09:27] Generating Benchmark Reports [completed]

Benchmark Reports    

JSON: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/compare.json

PDF: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/artifact-1.pdf

HTML: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/artifact-1.html

@lifeart lifeart merged commit 12a9f16 into master Jan 24, 2024
8 checks passed
@lifeart lifeart deleted the render-error-overlays branch January 24, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant