Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: switch tray items to listview #734

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

chore: switch tray items to listview #734

wants to merge 4 commits into from

Conversation

zsien
Copy link
Member

@zsien zsien commented Aug 30, 2024

  • tray 使用 listview 实现
  • stashed 使用 grid 实现
  • 修改 traysortordermodel

Issues: linuxdeepin/developer-center#10198

@zsien zsien requested a review from a team August 30, 2024 06:27
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zsien

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yixinshark yixinshark requested a review from BLumia August 30, 2024 07:15
BLumia
BLumia requested changes Aug 30, 2024
View reviewed changes
Copy link
Member

@BLumia BLumia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

之前是这里一开始没用 ListView 是因为 ListView 无法满足设计给定的动画要求。这里的动画要求非常复杂（细节你可以当面给 @tsic404 核对一下），此 PR 当前实现导致相应动画需求完全丢失，是不可接受的。

此外，Stash 区域的 item 存在不必要的动画，tray 区域拖拽时实时更新位置的动画也未实现，从快捷面板拖拽驻留的需求看上去也失效了。

（ps. Stash 区域最初没用 GridView 也是考虑到最初说允许 GridView 出现尺寸非固定的元素可能一个元素占据多个格子。目前没有再收到此类需求了，所以 Stash 区域改 GridView 应该问题不大）

@zsien zsien force-pushed the zs/chore/trayanimation branch 2 times, most recently from f6ae995 to 608a828 Compare September 2, 2024 08:20
@zsien
chore: switch tray items to listview
60ef3f8 
* tray 使用 listview 实现
* stashed 使用 grid 实现
* 修改 traysortordermodel

Issues: linuxdeepin/developer-center#10198
@zsien
fix: fix crashes
f8c5de6 
* 修复拖动到 show stash action 时崩溃
* 修复拖动后位置不变时崩溃
@zsien
chore: clean code
acb9ae2 
清理代码
@zsien
fix: cursor icon changed when dragging
383ecda 
增加覆盖整个 tray 区域的 DropArea
@deepin-ci-robot
Copy link

deepin pr auto review

Fix the TraySortOrderModel to work with the new model

@tsic404
Copy link
Contributor

tsic404 commented Sep 27, 2024

这个修改后托盘的效果没有达到之前的动画效果吧？

@deepin-bot
Copy link

deepin-bot bot commented Oct 31, 2024

TAG Bot

New tag: 1.99.3
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #846

@deepin-bot
Copy link

deepin-bot bot commented Nov 7, 2024

TAG Bot

New tag: 1.99.4
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #856

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BLumia BLumia BLumia requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zsien @deepin-ci-robot @tsic404 @BLumia