Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HeaderMap for headers in mock and response #179

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

andrewtoth
Copy link
Contributor

@andrewtoth andrewtoth commented Oct 30, 2023

This uses the http types HeaderMap, HeaderName and HeaderValue where appropriate, instead of Vec<(String, String)>. This disallows invalid header names at the call site.

This is a breaking change, because the functions Mock::match_header and Mock::with_header no longer accept &str. They will accept &'static str however.

@lipanski lipanski merged commit 9dae3ce into lipanski:master Nov 1, 2023
6 checks passed
@lipanski
Copy link
Owner

lipanski commented Nov 1, 2023

Thanks @andrewtoth 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants