Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add node 22 to engines (#900) #901

Merged
merged 1 commit into from
Nov 8, 2024
Merged

chore: add node 22 to engines (#900) #901

merged 1 commit into from
Nov 8, 2024

Conversation

fabiancook
Copy link
Contributor

Description

Related issues

Checklist

  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style
    guide

@fabiancook
chore: add node 22 to engines (loopbackio#900)
ca4708b 
Signed-off-by: Fabian Cook <hello@fabiancook.dev>
@fabiancook
Copy link
Contributor Author

Noting that node 22 is already within the github actions matrix

strong-soap/.github/workflows/continuous-integration.yaml

Line 22 in 815a8a4

node-version: [18, 20, 22]

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11732956364

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.651%
Totals Coverage Status
Change from base Build 11657687401: 0.0%
Covered Lines: 2894
Relevant Lines: 3248
💛 - Coveralls

achrinza
achrinza approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@achrinza achrinza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@achrinza achrinza merged commit a6266ff into loopbackio:master Nov 8, 2024
10 checks passed
@achrinza achrinza linked an issue Nov 8, 2024 that may be closed by this pull request
Node 22 #900
Closed
@achrinza achrinza mentioned this pull request Nov 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achrinza achrinza achrinza approved these changes

@raymondfeng raymondfeng Awaiting requested review from raymondfeng raymondfeng is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Node 22
3 participants
@fabiancook @coveralls @achrinza