Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added code to cleanup dev-package-list clone after installation #59

Merged
merged 3 commits into from
Jun 28, 2024
Merged

Added code to cleanup dev-package-list clone after installation #59

merged 3 commits into from
Jun 28, 2024

Conversation

mxturri
Copy link
Contributor

@mxturri mxturri commented Jun 28, 2024

No description provided.

@glennmorris glennmorris added the enhancement New feature or request label Jun 28, 2024
@glennmorris glennmorris self-requested a review June 28, 2024 19:13
glennmorris
glennmorris approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@glennmorris glennmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, although if really want to ensure proper cleanup (eg if script aborts partway through), would use an EXIT trap.

@glennmorris glennmorris merged commit 1abb746 into master Jun 28, 2024
16 checks passed
@glennmorris glennmorris deleted the IT-5368-cleanup branch June 28, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glennmorris glennmorris glennmorris approved these changes

Assignees

@glennmorris glennmorris

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxturri @glennmorris