feat: Launch tests and prod proposals #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deluca-mike
force-pushed
the
feat/launch-tests
branch
2 times, most recently
from
09e55bb
to
b354695
Compare
PierrickGT
requested changes
May 7, 2024
test/Integration.t.sol
Outdated
| uint256[] internal _minterKeys; | ||
| uint256[] internal _validatorKeys; | ||
|
|
||
| uint256[][2] internal _initialBalances; | ||
| address[][2] internal _initialAccounts = [ |
There was a problem hiding this comment.
Should live in a TestUtils file if we want to reuse it across tests.
There was a problem hiding this comment.
For now, there are only 3 tests. But if we made more off mainnet, then this file would become an IntergrationtestBase, and tests would be moved elsewhere. These are fixtures, not utils.
|
|
||
| function _encodeSetMintDelay(uint256 mintDelay_) internal pure returns (bytes memory) { | ||
| return abi.encodeWithSelector(IStandardGovernor.setKey.selector, _MINT_DELAY, mintDelay_); | ||
| function _encodeAdd(bytes32 list_, address account_) internal pure returns (bytes memory) { |
There was a problem hiding this comment.
These helper functions should live in a TestUtils file.
There was a problem hiding this comment.
Agreed, but there is no TestUtils file yet, and this file itself might become a TestBase as the tests are moved elsewhere.
deluca-mike
force-pushed
the
feat/launch-tests
branch
2 times, most recently
from
bb88b1d
to
9a2efb4
Compare
PierrickGT
approved these changes
May 10, 2024
PierrickGT
force-pushed
the
feat/launch-tests
branch
from
9a2efb4
to
0c3d0ee
Compare
PierrickGT
force-pushed
the
feat/launch-tests
branch
2 times, most recently
from
05dbb87
to
1631dd7
Compare
PierrickGT
force-pushed
the
feat/launch-tests
branch
from
1631dd7
to
b490314
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.