more tests, some renames

m0-foundation · Jul 3, 2024 · e9cbaf4 · e9cbaf4
1 parent b39b8c2
commit e9cbaf4
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 6 deletions.
diff --git a/src/WrappedMToken.sol b/src/WrappedMToken.sol
@@ -79,7 +79,7 @@ contract WrappedMToken is IWrappedMToken, Migratable, ERC20Extended {
     }
 
     function startEarningM() external {
-        if (mIndexWhenEarningStopped != 0) revert OnlyEarningOnce();
+        if (mIndexWhenEarningStopped != 0) revert AllowedToEarnOnlyOnce();
 
         IMTokenLike(mToken).startEarning();
     }

diff --git a/src/interfaces/IWrappedMToken.sol b/src/interfaces/IWrappedMToken.sol
@@ -41,10 +41,10 @@ interface IWrappedMToken is IMigratable, IERC20Extended {
     /// @notice Emitted when calling `startEarning` for an account not approved as earner by TTG.
     error NotApprovedEarner();
 
-    /// @notice Emitted when calling `startEarningM` after wrapper was already in earning state once.
-    error OnlyEarningOnce();
+    /// @notice Emitted when calling `startEarningM` after Wrapped M was already earning M yield once.
+    error AllowedToEarnOnlyOnce();
 
-    /// @notice Emitted when method is called when Wrapped M is not in earning state.
+    /// @notice Emitted when calling `startEarningFor` if Wrapped M is not in earning state.
     error NotInEarningState();
 
     /// @notice Emitted in constructor if M Token is 0x0.

diff --git a/test/WrappedMToken.t.sol b/test/WrappedMToken.t.sol
@@ -368,6 +368,15 @@ contract WrappedMTokenTests is Test {
         _wrappedMToken.startEarningFor(_alice);
     }
 
+    function test_startEarningFor_notInEarningState() external {
+        _mToken.stopEarning(address(_wrappedMToken));
+
+        _registrar.setListContains(_EARNERS_LIST, _alice, true);
+
+        vm.expectRevert(IWrappedMToken.NotInEarningState.selector);
+        _wrappedMToken.startEarningFor(_alice);
+    }
+
     function test_startEarningFor() external {
         _wrappedMToken.setTotalNonEarningSupply(1_000);
 
@@ -433,12 +442,12 @@ contract WrappedMTokenTests is Test {
     }
 
     /* ============ startEarningM ============ */
-    function test_startEarningM_onlyEarningOnce() external {
+    function test_startEarningM_allowedToEarnOnlyOnce() external {
         assertEq(_mToken.isEarning(address(_wrappedMToken)), true);
 
         _wrappedMToken.stopEarningM();
 
-        vm.expectRevert(IWrappedMToken.OnlyEarningOnce.selector);
+        vm.expectRevert(IWrappedMToken.AllowedToEarnOnlyOnce.selector);
         _wrappedMToken.startEarningM();
     }
 

diff --git a/test/utils/Mocks.sol b/test/utils/Mocks.sol
@@ -37,6 +37,10 @@ contract MockM {
     function stopEarning() external {
         isEarning[msg.sender] = false;
     }
+
+    function stopEarning(address earner) external {
+        isEarning[earner] = false;
+    }
 }
 
 contract MockRegistrar {