Skip to content

Commit

Permalink
Merge pull request #169 from macielti/metric-v2
Browse files Browse the repository at this point in the history
Added `http-request-in-handle-timing-v2` summary metric
  • Loading branch information
macielti authored Nov 17, 2024
2 parents d512eed + 0e1e6eb commit f5d6b47
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 3 deletions.
16 changes: 15 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,18 @@ of [keepachangelog.com](http://keepachangelog.com/).

## [Unreleased]

## [39.72.72] - 2024-11-17

### Added

- Added `:http-request-in-handle-timing-v2` (summary) Prometheus component metric to measure the time spent while
handling http requests.

### Removed

- Removed `:http-request-in-handle-timing` Prometheus component metric to measure the time spent while handling http
requests.

## [38.72.72] - 2024-11-16

### Changed
Expand Down Expand Up @@ -1087,7 +1099,9 @@ of [keepachangelog.com](http://keepachangelog.com/).

- Add `loose-schema` function.

[Unreleased]: https://github.com/macielti/common-clj/compare/v38.72.72...HEAD
[Unreleased]: https://github.com/macielti/common-clj/compare/v39.72.72...HEAD

[39.72.72]: https://github.com/macielti/common-clj/compare/v38.72.72...v39.72.72

[38.72.72]: https://github.com/macielti/common-clj/compare/v38.72.71...v38.72.72

Expand Down
2 changes: 1 addition & 1 deletion project.clj
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
(defproject net.clojars.macielti/common-clj "38.72.72"
(defproject net.clojars.macielti/common-clj "39.72.72"

:description "Just common Clojure code that I use across projects"

Expand Down
3 changes: 2 additions & 1 deletion src/common_clj/integrant_components/prometheus.clj
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@

(def default-metrics
[(prometheus/counter :http-request-response {:labels [:status :service :endpoint]})
(prometheus/histogram :http-request-in-handle-timing {:labels [:service :endpoint]})])
(prometheus/summary :http-request-in-handle-timing-v2 {:labels [:service :endpoint]
:quantiles {0.5 0.05, 0.9 0.1, 0.99 0.001}})])

(defmethod ig/init-key ::prometheus
[_ {:keys [metrics]}]
Expand Down

0 comments on commit f5d6b47

Please sign in to comment.