Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/37591 cart price rule incorect descount percent #39352

Open
wants to merge 3 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

dmrkato
Copy link

@dmrkato dmrkato commented Nov 10, 2024

Description Cart price rules - Incorrect discount percent calculation when applying 2 or more sales rules by percent

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Cart price rules - Incorrect discount percent calculation when applying 2 and more sales rules by percent #37591
  2. Jira issue https://jira.corp.adobe.com/browse/AC-9120

Manual testing scenarios (*)

  1. Create 2 sales rules by percent
    1.1. Create 50% percent discount rule for the tested product item (set Discard subsequent rules to No value - need to apply few sales rules)
    1.2 Create 50% percent discount rule for the tested product item by using coupon code
  2. As a result total discount should be 75%

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Copy link

m2-assistant bot commented Nov 10, 2024

Hi @dmrkato. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@engcom-Hotel engcom-Hotel added the Priority: P3 May be fixed according to the position in the backlog. label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P3 May be fixed according to the position in the backlog. Progress: pending review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cart price rules - Incorrect discount percent calculation when applying 2 and more sales rules by percent
2 participants