Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds basic formatting #23

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Adds basic formatting #23

merged 1 commit into from
Jun 4, 2024

Conversation

nateconley
Copy link
Collaborator

Description of the Change

Adds basic formatting. This PR is intended to have only changes which should not possibly have an impact on functionality.

A first iteration on #12

Examples:

  1. Whitespace
  2. Alignment
  3. Yoda conditionals
  4. Remove echo sprintf and use printf

How to test the Change

  1. No functional or visual regressions.

Changelog Entry

Fixed - Formatting

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change. - n/a
  • All new and existing tests pass. - Not intended to make phpcs fully pass at this iteration

@github-actions github-actions bot added this to the 1.6.0 milestone Jun 4, 2024
@github-actions github-actions bot added the needs:feedback This requires reporter feedback to better understand the request. label Jun 4, 2024
Copy link

github-actions bot commented Jun 4, 2024

@nateconley thanks for the PR! Could you please fill out the PR template with description, changelog, and credits information so that we can properly review and merge this?

@nateconley nateconley requested a review from dkotter June 4, 2024 01:18
Copy link
Collaborator

@dkotter dkotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, going to merge this in so other PRs can take advantage of this cleanup. Noting at some point it would probably be good to add PHP headers to those view files, especially the ones that don't have any PHP, I think we can include a PHP header that explains what the file does which will also resolve a PHPCS lint issue

@dkotter dkotter merged commit 66aaf7f into develop Jun 4, 2024
0 of 3 checks passed
@dkotter dkotter deleted the fix/formatting branch June 4, 2024 16:07
@vikrampm1 vikrampm1 mentioned this pull request Jun 26, 2024
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:feedback This requires reporter feedback to better understand the request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants