Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [BaseBuilder] Removed redundant || $val instanceof RawSql check from the foreach loop. #4

Closed
wants to merge 1 commit into from

Conversation

maniaba
Copy link
Owner

@maniaba maniaba commented Nov 13, 2024

Description

The redundant || $val instanceof RawSql check has been removed from the foreach loop because the preceding code already ensures that $object cannot be an instance of RawSql. This makes the condition unnecessary and simplifies the logic.

if ($object instanceof RawSql) {

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@maniaba maniaba self-assigned this Nov 13, 2024
@maniaba maniaba closed this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant