QScintilla (GPL) and ScintillaEdit (MIT) support #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not an expert on Qt or C++, but is there any chance for the binding to use Scintilla component (https://www.scintilla.org) which has permissive license directly? I noticed in their source there are Qt components (ScintillaEditBase and ScintillaEdit). |
|
@jamalsa That's really interesting, thank you for pointing it out. ScintillaEdit builds cleanly for me, it seems like a less featureful binding than QScintilla (no signals at all) but the license is definitely preferable. Let's add both, |
mappu
changed the title
mappu
force-pushed
the
miqt-scintilla
branch
2 times, most recently
from
9fbb694
to
04766c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates: #5
Updates: #45
Requires: #47
Adds bindings for QScintilla. This library is GPL/Commercial only⚠️ and is put in a new
restricted-extrassection.Adds bindings for ScintillaEdit (MIT).
Screenshots: