Modify qt6/cbor for proper builds #82
Merged
+1,004
−106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested with Debian 12 and Qt 6.4
|
Should I include the diffs here? I can do whatever you'd like but I imagine you would prefer that they match your expectations. Feel free to push to this branch too. I'll try not to rebase over it. 😅 |
|
Thanks - really nice find 🤦 Yes, I think generally the Qt diffs should be included in the PR (maybe as a second commit). The CI pipeline has a step that re-runs genbindings, to make sure that the bindings can always be generated cleanly with no diff. I'll push the diffs to your branch now, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with Debian 12 and Qt 6.4