Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for additional HTML attributes in HTML5 template #238

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

wneessen
Copy link
Contributor

@wneessen wneessen commented Nov 5, 2024

This PR updates the HTML5 function to accept and render additional HTML attributes. An additional test case to validate this enhancement has been added as well.

Updated the HTML5 function to accept and render additional HTML attributes. Added a new test case to validate this enhancement.
@markuswustenberg
Copy link
Member

Looks good, thanks!

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (033f6ac) to head (60a8d25).
Report is 32 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #238   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         5    -4     
  Lines          534       534           
=========================================
  Hits           534       534           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@markuswustenberg markuswustenberg merged commit c366cfc into maragudk:main Nov 6, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants