feat: Add a "--scheduler-key" flag to override scheduler key to use #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koloz193
reviewed
Feb 26, 2024
src/main.rs
Outdated
| @@ -59,6 +60,8 @@ struct Cli { | |||
| /// Flag to print output as json | |||
| #[arg(long)] | |||
| json: bool, | |||
| #[arg(long, default_value="")] | |||
| scheduler_key: String, | |||
There was a problem hiding this comment.
nit: can make this an Option
src/utils.rs
Outdated
| @@ -3,12 +3,17 @@ use std::env; | |||
| /// Checks to see if the verification key exists for a given protocol version or an update has been requested and downloads it from github if needed. | |||
| pub async fn check_verification_key(protocol_version: String) { | |||
| let file_path = format!("src/keys/protocol_version/{}/scheduler_key.json", protocol_version); | |||
| // If the key for the latest protocol version is nout available in this repo yet, you can always find it at https://github.com/matter-labs/era-contracts/blob/main/tools/data/scheduler_key.json | |||
There was a problem hiding this comment.
typo - "nout" vs "not"
saaqibz
force-pushed
the
saz/schedulerKeyOverride
branch
from
7822d21
to
ceff956
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
example usage:
assuming old is the key for protocol version 18 and new is version 19. The first call will work and the second call will return an
assertion `left == right` failederror