Skip to content

Commit

Permalink
fix incorrect block hash in eth_getTransactionReceipt (#122)
Browse files Browse the repository at this point in the history
  • Loading branch information
nbaztec authored Sep 18, 2023
1 parent 2235ecd commit 599758f
Showing 1 changed file with 16 additions and 1 deletion.
17 changes: 16 additions & 1 deletion src/node.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1496,7 +1496,7 @@ impl<S: Send + Sync + 'static + ForkSource + std::fmt::Debug> EthNamespaceT for
let receipt = tx_result.map(|info| TransactionReceipt {
transaction_hash: hash,
transaction_index: U64::from(1),
block_hash: Some(hash),
block_hash: reader.block_hashes.get(&info.miniblock_number).cloned(),
block_number: Some(U64::from(info.miniblock_number)),
l1_batch_tx_index: None,
l1_batch_number: Some(U64::from(info.batch_number as u64)),
Expand Down Expand Up @@ -2678,4 +2678,19 @@ mod tests {
);
}
}

#[tokio::test]
async fn test_get_transaction_receipt_uses_produced_block_hash() {
let node = InMemoryNode::<HttpForkSource>::default();
let tx_hash = H256::repeat_byte(0x01);
let expected_block_hash = testing::apply_tx(&node, tx_hash);

let actual_tx_receipt = node
.get_transaction_receipt(tx_hash)
.await
.expect("failed fetching transaction receipt by hash")
.expect("no transaction receipt");

assert_eq!(Some(expected_block_hash), actual_tx_receipt.block_hash);
}
}

0 comments on commit 599758f

Please sign in to comment.