Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bump hh deploy and solc versions #110

Merged
merged 10 commits into from
Sep 15, 2023
Merged

fix: Bump hh deploy and solc versions #110

merged 10 commits into from
Sep 15, 2023

Conversation

idea404
Copy link
Contributor

@idea404 idea404 commented Sep 12, 2023

What 💻

  • Bump hardhat zksync deploy and solc versions

Why ✋

  • Fetches binaries from GH Releases CDN instead of repositories (related to Headers Timeout Errors found last week)

@idea404
Copy link
Contributor Author

idea404 commented Sep 13, 2023

This PR reintroduces a function that was removed between the hardhat-zksync-solc versions 0.3.15 to 0.4.2, namely this piece of code:

import path from "path";
import { getCompilersDir } from "hardhat/internal/util/global-dir";
export async function getZksolcPath(version: string, salt: string = ""): Promise<string> {
  return path.join(await getCompilersDir(), "zksolc", `zksolc-v${version}${salt ? "-" : ""}${salt}`);
}

Since there is no formatting on scripts or this project level I skipped formatting the file.

@idea404 idea404 requested a review from a team as a code owner September 13, 2023 17:03
Copy link
Collaborator

@MexicanAce MexicanAce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MexicanAce MexicanAce merged commit be53aec into main Sep 15, 2023
8 checks passed
@MexicanAce MexicanAce deleted the fix/bump-hh branch September 15, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants