Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: enforce conventional commits on main #113

Merged
merged 3 commits into from
Sep 13, 2023
Merged

chore: enforce conventional commits on main #113

merged 3 commits into from
Sep 13, 2023

Conversation

MexicanAce
Copy link
Collaborator

@MexicanAce MexicanAce commented Sep 13, 2023 •
edited
Loading

What 💻

  • Enforce conventional commits on PRs (merges to main branch)
  • Update CODEOWNERS to be entire team
  • Fix broken link in SUPPORTED_APIS.md

Why ✋

  • Standardized and automated release notes
  • To keep the list of engineers more open as the team changes over time
  • Link was malformed

Evidence 📷

TBD (I'm unable to validate with the current run criteria, so will merge and validate in subsequent PR to ensure permissions are correct)

Notes 📝

  • This works as a level of enforcement because we only allow squash merging of PRs
  • See Conventional Commits Spec for more information

@MexicanAce MexicanAce changed the title chore: enforce conventional commits on main bad_name_should_fail enforce conventional commits on main Sep 13, 2023
@MexicanAce MexicanAce changed the title bad_name_should_fail enforce conventional commits on main chore: enforce conventional commits on main Sep 13, 2023
JackHamer09
JackHamer09 previously approved these changes Sep 13, 2023
View reviewed changes
@MexicanAce MexicanAce merged commit baa761e into main Sep 13, 2023
7 checks passed
@MexicanAce MexicanAce deleted the nmv/enforce-conventional-commits branch September 13, 2023 16:58
IAvecilla added a commit to lambdaclass/era-test-node that referenced this pull request Feb 29, 2024
@IAvecilla
Improve montgomeryAdd implementation (matter-labs#113)
f660dca 
* Make montgomery add more efficient

* Fix add montgomery for edge case

* Add montgomery add improvement for ecPairing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackHamer09 JackHamer09 JackHamer09 approved these changes

@dutterbutter dutterbutter dutterbutter approved these changes

@uF4No uF4No Awaiting requested review from uF4No

@mm-zk mm-zk Awaiting requested review from mm-zk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MexicanAce @dutterbutter @JackHamer09