Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bind server to 0.0.0.0 for external access #115

Merged
merged 1 commit into from
Sep 14, 2023
Merged

fix: bind server to 0.0.0.0 for external access #115

merged 1 commit into from
Sep 14, 2023

Conversation

JackHamer09
Copy link
Member

What 💻

  • Updated RPC server binding address from 127.0.0.1 to 0.0.0.0

Why ✋

  • To allow access to the in-memory node both via http://localhost:8011 and http://127.0.0.1:8011
  • To ensure compatibility with Docker containerization

Evidence 📷

image

Notes 📝

  • Previously it wasn't possible to access in memory node on http://localhost:8011 from the browser.

@JackHamer09 JackHamer09 requested a review from a team as a code owner September 14, 2023 09:26
MexicanAce
MexicanAce approved these changes Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@MexicanAce MexicanAce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MexicanAce MexicanAce merged commit d6529ab into main Sep 14, 2023
8 checks passed
@MexicanAce MexicanAce deleted the change-bind-address branch September 14, 2023 13:49
IAvecilla pushed a commit to lambdaclass/era-test-node that referenced this pull request Feb 29, 2024
@ColoCarletti
remove_switch_in_projectiveIntoAffine (matter-labs#115)
e155896
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MexicanAce MexicanAce MexicanAce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JackHamer09 @MexicanAce