Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update eth_call to serialize output data in console #140

Merged
merged 1 commit into from
Sep 28, 2023
Merged

chore: update eth_call to serialize output data in console #140

merged 1 commit into from
Sep 28, 2023

Conversation

MexicanAce
Copy link
Collaborator

What 💻

  • Update eth_call to serialize output data in console

Why ✋

  • So it's easier to read

Evidence 📷

This is purely a cosmetic change in the console logs

BEFORE:

19:36:22 [INFO] Call: SUCCESS [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 32, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 2, 72, 105, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0]
19:36:22 [INFO] === Console Logs: 
19:36:22 [INFO] === Call traces:

AFTER:

20:03:06 [INFO] Call: SUCCESS
20:03:06 [INFO] Output: "0x000000000000000000000000000000000000000000000000000000000000002000000000000000000000000000000000000000000000000000000000000000024869000000000000000000000000000000000000000000000000000000000000"
20:03:06 [INFO] === Console Logs: 
20:03:06 [INFO] === Call traces:

@MexicanAce MexicanAce linked an issue Sep 27, 2023 that may be closed by this pull request
Make output for Call SUCCESS easier to read #136
Closed
@MexicanAce MexicanAce marked this pull request as ready for review September 27, 2023 20:13
@MexicanAce MexicanAce requested a review from a team as a code owner September 27, 2023 20:13
@MexicanAce MexicanAce merged commit 3f8c893 into main Sep 28, 2023
8 checks passed
@MexicanAce MexicanAce deleted the 136-make-output-for-call-success-easier-to-read branch September 28, 2023 11:50
IAvecilla pushed a commit to lambdaclass/era-test-node that referenced this pull request Feb 29, 2024
@ilitteri
Remove unnecessary checks in ecAdd (matter-labs#144)
a891bb8 
* matter-labs#140

* matter-labs#141

* matter-labs#142
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dutterbutter dutterbutter dutterbutter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make output for Call SUCCESS easier to read
2 participants
@MexicanAce @dutterbutter