Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: showing low-level VM errors #311

Merged
merged 9 commits into from
Sep 26, 2024

Conversation

vbar
Copy link
Contributor

@vbar vbar commented Jul 9, 2024

What 💻

Added a tracer showing AfterDecodingData.error_flags_accumulated.

Why ✋

Implements #239 .

Evidence 📷

output

The error is triggered by running fib.ts from the attached
example.zip

@vbar vbar requested a review from a team as a code owner July 9, 2024 11:04
@MexicanAce
Copy link
Collaborator

Updated with the latest upstream changes and checked in the e2e test which throws NOT ENOUGH ERGS. Validated locally it also works for me:
image

Copy link
Collaborator

@MexicanAce MexicanAce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MexicanAce MexicanAce merged commit d35eb77 into matter-labs:main Sep 26, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants