feat: anvil API #313

vbar · 2024-07-11T06:10:28Z

What 💻

Added evm_setAccountNonce, anvil_setNonce, anvil_impersonateAccount, anvil_stopImpersonatingAccount, anvil_mine, anvil_reset, anvil_setBalance, anvil_setCode and anvil_setStorageAt as aliases to the corresponding hardhat_* methods.

Why ✋

Implements #160 .

Evidence 📷

Extended e2e tests, which pass.

SUPPORTED_APIS.md

e2e-tests/test/anvil-apis.test.ts

to actually call hardhat_stopImpersonatingAccount, interfere less with other tests

AnastasiiaVashchuk · 2024-07-31T11:22:40Z

@vbar what about other endpoints?
I checked the endpoints list here - https://book.getfoundry.sh/reference/anvil/
There are many more methods.

vbar · 2024-07-31T11:31:36Z

@vbar what about other endpoints? I checked the endpoints list here - https://book.getfoundry.sh/reference/anvil/ There are many more methods.

Well, yes, but not all of them can be supported by the test node - so I wanted to start with the obvious aliases...

MexicanAce · 2024-07-31T11:53:33Z

@vbar what about other endpoints?
I checked the endpoints list here - https://book.getfoundry.sh/reference/anvil/
There are many more methods.

The point of having anvil endpoints is so tools like Rivet work with era-test-node. We shouldn't be adding anvil_ endpoints if they aren't being used upstream.

To that end, there's no need to implement every endpoint. I would spin up that chrome extension tool and see what's required

vbar · 2024-07-31T11:55:53Z

The point of having anvil endpoints is so tools like Rivet work with era-test-node. We shouldn't be adding anvil_ endpoints if they aren't being used upstream.

To that end, there's no need to implement every endpoint. I would spin up that chrome extension tool and see what's required

Err, do you have a cookbook? I tried that, and it didn't work at all...

MexicanAce · 2024-07-31T11:57:19Z

The point of having anvil endpoints is so tools like Rivet work with era-test-node. We shouldn't be adding anvil_ endpoints if they aren't being used upstream.

To that end, there's no need to implement every endpoint. I would spin up that chrome extension tool and see what's required

Err, do you have a cookbook? I tried that, and it didn't work at all...

Nope. They've made a lot of changes since I last got it barely working, so this requires some exploratory investigation

This reverts commit 4a54fe8.

AnastasiiaVashchuk · 2024-07-31T12:36:00Z

The point of having anvil endpoints is so tools like Rivet work with era-test-node. We shouldn't be adding anvil_ endpoints if they aren't being used upstream.
To that end, there's no need to implement every endpoint. I would spin up that chrome extension tool and see what's required

Err, do you have a cookbook? I tried that, and it didn't work at all...

Nope. They've made a lot of changes since I last got it barely working, so this requires some exploratory investigation

that's are endpoints probably used by River, but I am not sure. @vbar we need to check.

anvil_getLogs
anvil_getBlock
anvil_getTransaction
anvil_getReceipt
anvil_setBalance
anvil_mine
anvil_dropTransaction
anvil_impersonateAccount
anvil_stopImpersonatingAccount

SUPPORTED_APIS.md

Co-authored-by: AnastasiiaVashchuk <72273339+AnastasiiaVashchuk@users.noreply.github.com>

SUPPORTED_APIS.md

e2e-tests/test/anvil-apis.test.ts

AnastasiiaVashchuk · 2024-08-15T07:19:39Z

anvil_setStorageAt, anvil_impersonateAccount , anvil_stopImpersonatingAccount - are used by rivet.
JFYI.

src/namespaces/anvil.rs

Co-authored-by: AnastasiiaVashchuk <72273339+AnastasiiaVashchuk@users.noreply.github.com>

e2e-tests/test/zks-apis.test.ts

e2e-tests/test/main.test.ts

* fix: changed evm_setNextBlockTimestamp (#321) * changed evm_setNextBlockTimestamp argument type to U64 * fixed caller of evm_setNextBlockTimestamp * setting the timestamp of the next block in evm_setNextBlockTimestamp * formatted * updated comment * fix: returning errors from fork handling (#335) * not panicking in is_write_initial_internal * not panicking in fork_network_and_client * not panicking in get_earlier_transactions_in_same_block * not panicking in get_block_gas_details * Update src/fork.rs Co-authored-by: AnastasiiaVashchuk <72273339+AnastasiiaVashchuk@users.noreply.github.com> * more specific error message * more specific error message * added miniblock number to error message --------- Co-authored-by: AnastasiiaVashchuk <72273339+AnastasiiaVashchuk@users.noreply.github.com> * feat: anvil API (#313) * added evm_setAccountNonce alias * added anvil_setNonce alias * added anvil_impersonateAccount & anvil_stopImpersonatingAccount aliases * added anvil_mine alias * added anvil_reset alias * added anvil_setBalance alias * added anvil_setCode alias * added anvil_setStorageAt alias * added anvil_* aliases * added anvil_mine test * modified hardhat_impersonateAccount & hardhat_stopImpersonatingAccount to actually call hardhat_stopImpersonatingAccount, interfere less with other tests * added anvil_impersonateAccount & anvil_stopImpersonatingAccount test * added anvil_setCode test * added hardhat_setStorageAt and anvil_setStorageAt tests * formatted * removed links to anvil namespace * split tables * Revert "split tables" This reverts commit 4a54fe8. * renamed AnvilNamespaceT::hardhat_mine to anvil_mine * Update SUPPORTED_APIS.md Co-authored-by: AnastasiiaVashchuk <72273339+AnastasiiaVashchuk@users.noreply.github.com> * added section for evm_setAccountNonce * changed var to let to satisfy linter * using random address in anvil_setCode test * added semicolon * named test account address * changed var to let to satisfy linter * Update src/namespaces/anvil.rs Co-authored-by: AnastasiiaVashchuk <72273339+AnastasiiaVashchuk@users.noreply.github.com> * removed to.be.within checks * supressing TypeScript errors * supressing TypeScript errors * changed anvil_setCode code type * using find instead of an explicit loop --------- Co-authored-by: AnastasiiaVashchuk <72273339+AnastasiiaVashchuk@users.noreply.github.com> * test: Add test for hardhat_reset (#333) * add test and do follow up fixes * run lint * fix nits * fix: Update gas estimation logic for forks (#339) * fix: fork gas estimation * Additional fixes * chore: Update release version (#340) * chore: fix tests after the gas changes * test: fix unit tests --------- Co-authored-by: Vaclav Barta <vbarta@mangrove.cz> Co-authored-by: AnastasiiaVashchuk <72273339+AnastasiiaVashchuk@users.noreply.github.com> Co-authored-by: Nicolas Villanueva <1890113+MexicanAce@users.noreply.github.com>

vbar added 8 commits July 10, 2024 12:35

added evm_setAccountNonce alias

052530b

added anvil_setNonce alias

a2d1f0d

added anvil_impersonateAccount & anvil_stopImpersonatingAccount aliases

7ab50f0

added anvil_mine alias

37e6bf5

added anvil_reset alias

f083ab2

added anvil_setBalance alias

08eaafa

added anvil_setCode alias

f76d5e6

added anvil_setStorageAt alias

6f4c64d

vbar requested a review from a team as a code owner July 11, 2024 06:10

AnastasiiaVashchuk reviewed Jul 23, 2024

View reviewed changes

SUPPORTED_APIS.md Show resolved Hide resolved

AnastasiiaVashchuk reviewed Jul 23, 2024

View reviewed changes

e2e-tests/test/anvil-apis.test.ts Show resolved Hide resolved

AnastasiiaVashchuk reviewed Jul 23, 2024

View reviewed changes

e2e-tests/test/anvil-apis.test.ts Show resolved Hide resolved

vbar added 8 commits July 24, 2024 09:10

added anvil_* aliases

b5dc622

added anvil_mine test

7b8392b

modified hardhat_impersonateAccount & hardhat_stopImpersonatingAccount

34c9dd0

to actually call hardhat_stopImpersonatingAccount, interfere less with other tests

added anvil_impersonateAccount & anvil_stopImpersonatingAccount test

0373993

added anvil_setCode test

97b943b

added hardhat_setStorageAt and anvil_setStorageAt tests

ac62abf

formatted

a14ca13

Merge branch 'main' into anvil-api

90a1216

vbar requested a review from AnastasiiaVashchuk July 25, 2024 06:03

removed links to anvil namespace

d36852f

vbar added 2 commits July 31, 2024 14:14

split tables

4a54fe8

Revert "split tables"

bcb3397

This reverts commit 4a54fe8.

renamed AnvilNamespaceT::hardhat_mine to anvil_mine

db1269b

AnastasiiaVashchuk reviewed Aug 14, 2024

View reviewed changes

SUPPORTED_APIS.md Outdated Show resolved Hide resolved

Update SUPPORTED_APIS.md

781c5a0

Co-authored-by: AnastasiiaVashchuk <72273339+AnastasiiaVashchuk@users.noreply.github.com>

AnastasiiaVashchuk reviewed Aug 14, 2024

View reviewed changes

SUPPORTED_APIS.md Show resolved Hide resolved

added section for evm_setAccountNonce

0ed672c

AnastasiiaVashchuk reviewed Aug 14, 2024

View reviewed changes

e2e-tests/test/anvil-apis.test.ts Outdated Show resolved Hide resolved

AnastasiiaVashchuk reviewed Aug 14, 2024

View reviewed changes

e2e-tests/test/anvil-apis.test.ts Outdated Show resolved Hide resolved

vbar added 4 commits August 14, 2024 12:18

changed var to let to satisfy linter

5857b4b

using random address in anvil_setCode test

879ac94

added semicolon

6befae3

named test account address

5ded038

AnastasiiaVashchuk reviewed Aug 14, 2024

View reviewed changes

e2e-tests/test/anvil-apis.test.ts Show resolved Hide resolved

changed var to let to satisfy linter

ee3da1e

AnastasiiaVashchuk reviewed Aug 15, 2024

View reviewed changes

src/namespaces/anvil.rs Outdated Show resolved Hide resolved

Update src/namespaces/anvil.rs

2440f93

Co-authored-by: AnastasiiaVashchuk <72273339+AnastasiiaVashchuk@users.noreply.github.com>

AnastasiiaVashchuk reviewed Aug 15, 2024

View reviewed changes

e2e-tests/test/zks-apis.test.ts Outdated Show resolved Hide resolved

removed to.be.within checks

5ff2701

AnastasiiaVashchuk reviewed Aug 15, 2024

View reviewed changes

e2e-tests/test/zks-apis.test.ts Outdated Show resolved Hide resolved

vbar added 4 commits August 15, 2024 10:27

supressing TypeScript errors

1f8a1f4

supressing TypeScript errors

2fd9f3f

Merge branch 'main' into anvil-api

bf3e63b

changed anvil_setCode code type

18fb136

AnastasiiaVashchuk reviewed Aug 27, 2024

View reviewed changes

e2e-tests/test/main.test.ts Outdated Show resolved Hide resolved

vbar and others added 2 commits August 27, 2024 12:22

using find instead of an explicit loop

bb26813

Merge branch 'main' into anvil-api

0c62782

AnastasiiaVashchuk approved these changes Aug 27, 2024

View reviewed changes

AnastasiiaVashchuk merged commit 706d726 into matter-labs:main Aug 27, 2024
10 checks passed

MexicanAce mentioned this pull request Sep 18, 2024

zks_estimateFee test fails when run standalone #320

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: anvil API #313

feat: anvil API #313

vbar commented Jul 11, 2024

AnastasiiaVashchuk commented Jul 31, 2024

vbar commented Jul 31, 2024

MexicanAce commented Jul 31, 2024

vbar commented Jul 31, 2024

MexicanAce commented Jul 31, 2024

AnastasiiaVashchuk commented Jul 31, 2024 •

edited

Loading

AnastasiiaVashchuk commented Aug 15, 2024

feat: anvil API #313

feat: anvil API #313

Conversation

vbar commented Jul 11, 2024

What 💻

Why ✋

Evidence 📷

AnastasiiaVashchuk commented Jul 31, 2024

vbar commented Jul 31, 2024

MexicanAce commented Jul 31, 2024

vbar commented Jul 31, 2024

MexicanAce commented Jul 31, 2024

AnastasiiaVashchuk commented Jul 31, 2024 • edited Loading

AnastasiiaVashchuk commented Aug 15, 2024

AnastasiiaVashchuk commented Jul 31, 2024 •

edited

Loading