fix: Update gas estimation logic for forks #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsacoyote
approved these changes
Sep 6, 2024
vasyl-ivanchuk
added a commit
that referenced
this pull request
Sep 9, 2024
* fix: changed evm_setNextBlockTimestamp (#321) * changed evm_setNextBlockTimestamp argument type to U64 * fixed caller of evm_setNextBlockTimestamp * setting the timestamp of the next block in evm_setNextBlockTimestamp * formatted * updated comment * fix: returning errors from fork handling (#335) * not panicking in is_write_initial_internal * not panicking in fork_network_and_client * not panicking in get_earlier_transactions_in_same_block * not panicking in get_block_gas_details * Update src/fork.rs Co-authored-by: AnastasiiaVashchuk <72273339+AnastasiiaVashchuk@users.noreply.github.com> * more specific error message * more specific error message * added miniblock number to error message --------- Co-authored-by: AnastasiiaVashchuk <72273339+AnastasiiaVashchuk@users.noreply.github.com> * feat: anvil API (#313) * added evm_setAccountNonce alias * added anvil_setNonce alias * added anvil_impersonateAccount & anvil_stopImpersonatingAccount aliases * added anvil_mine alias * added anvil_reset alias * added anvil_setBalance alias * added anvil_setCode alias * added anvil_setStorageAt alias * added anvil_* aliases * added anvil_mine test * modified hardhat_impersonateAccount & hardhat_stopImpersonatingAccount to actually call hardhat_stopImpersonatingAccount, interfere less with other tests * added anvil_impersonateAccount & anvil_stopImpersonatingAccount test * added anvil_setCode test * added hardhat_setStorageAt and anvil_setStorageAt tests * formatted * removed links to anvil namespace * split tables * Revert "split tables" This reverts commit 4a54fe8. * renamed AnvilNamespaceT::hardhat_mine to anvil_mine * Update SUPPORTED_APIS.md Co-authored-by: AnastasiiaVashchuk <72273339+AnastasiiaVashchuk@users.noreply.github.com> * added section for evm_setAccountNonce * changed var to let to satisfy linter * using random address in anvil_setCode test * added semicolon * named test account address * changed var to let to satisfy linter * Update src/namespaces/anvil.rs Co-authored-by: AnastasiiaVashchuk <72273339+AnastasiiaVashchuk@users.noreply.github.com> * removed to.be.within checks * supressing TypeScript errors * supressing TypeScript errors * changed anvil_setCode code type * using find instead of an explicit loop --------- Co-authored-by: AnastasiiaVashchuk <72273339+AnastasiiaVashchuk@users.noreply.github.com> * test: Add test for hardhat_reset (#333) * add test and do follow up fixes * run lint * fix nits * fix: Update gas estimation logic for forks (#339) * fix: fork gas estimation * Additional fixes * chore: Update release version (#340) * chore: fix tests after the gas changes * test: fix unit tests --------- Co-authored-by: Vaclav Barta <vbarta@mangrove.cz> Co-authored-by: AnastasiiaVashchuk <72273339+AnastasiiaVashchuk@users.noreply.github.com> Co-authored-by: Nicolas Villanueva <1890113+MexicanAce@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What 💻
max_gasduring transaction validation is increased fromu32::MAXtou64::MAXWhy ✋
era_test_nodecan mine blocks much faster than Sepolia Testnet, so sometimes it would require block details for a block that doesn't exist yet.1.5.0upgrade, the gas limit of ZKsync was upgraded fromu32tou64. This check was missed in the updates forera-test-nodeEvidence 📷
Forking sepolia and running a transaction still works
Notes 📝