refactor: move time management into its own component #385
+133
−89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itegulov
force-pushed
the
daniyar/timestamp-manager
branch
from
994353a
to
655dfeb
Compare
itegulov
commented
Nov 18, 2024
| return time_delta_seconds; | ||
| } | ||
|
|
||
| let time_delta = time_delta_seconds.saturating_mul(1000); |
There was a problem hiding this comment.
Not sure if I am missing something but I don't think there ever was a reason to multiply by a 1000 here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What 💻
Makes time management less rigid by moving the logic into its own component.
Closes #386
Why ✋
Some flows depend on getting unique timestamps (e.g. new block, new batch, etc) and they really shouldn't hold a mutable reference to the node's internal state all the time.