Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Included first test for GitLab code preview #109

Merged
merged 3 commits into from
Oct 4, 2023

Conversation

DHaussermann
Copy link
Contributor

Summary

This is the first test added for the GitLab code preview functionality new in v1.7.0

note: This is the first of several tests. I wanted to make a commit to work though the process.

Typical format for test cases:

Test coverage for mattermost/mattermost-plugin-gitlab#299

Is the feature in stable branch or under review?

  • Feature in stable branch (master, main)?

Test client

  • Browser
  • Desktop App (version, OS)

Copy link
Member

@saturninoabril saturninoabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DHaussermann! Looks good to me except one request.

Copy link
Collaborator

@yasserfaraazkhan yasserfaraazkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this.

Copy link
Member

@saturninoabril saturninoabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DHaussermann!

@saturninoabril saturninoabril added the 3: Reviews Complete All reviewers have approved the pull request label Oct 4, 2023
@saturninoabril saturninoabril merged commit 11082cb into main Oct 4, 2023
1 check passed
@saturninoabril saturninoabril deleted the gitlab-code-preview branch October 4, 2023 09:13
@saturninoabril
Copy link
Member

Test case saved: MM-T5454: Code Preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants