Skip to content

Commit

Permalink
Fix -Wmissing-template-arg-list-after-template-kw issued by Clang 19 (#…
Browse files Browse the repository at this point in the history
…73)

This warning is treated as error by default:
https://releases.llvm.org/19.1.0/tools/clang/docs/DiagnosticsReference.html#wmissing-template-arg-list-after-template-kw
So build breaks for all library consumers even when -Werror, -Wall, etc. are not used.
  • Loading branch information
dummyunit authored Oct 1, 2024
1 parent cf52f25 commit eaf3037
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions include/atomic_queue/atomic_queue.h
Original file line number Diff line number Diff line change
Expand Up @@ -404,13 +404,13 @@ class AtomicQueue2 : public AtomicQueueCommon<AtomicQueue2<T, SIZE, MINIMIZE_CON

T do_pop(unsigned tail) noexcept {
unsigned index = details::remap_index<SHUFFLE_BITS>(tail % size_);
return Base::template do_pop_any(states_[index], elements_[index]);
return Base::do_pop_any(states_[index], elements_[index]);
}

template<class U>
void do_push(U&& element, unsigned head) noexcept {
unsigned index = details::remap_index<SHUFFLE_BITS>(head % size_);
Base::template do_push_any(std::forward<U>(element), states_[index], elements_[index]);
Base::do_push_any(std::forward<U>(element), states_[index], elements_[index]);
}

public:
Expand Down Expand Up @@ -535,13 +535,13 @@ class AtomicQueueB2 : private std::allocator_traits<A>::template rebind_alloc<un

T do_pop(unsigned tail) noexcept {
unsigned index = details::remap_index<SHUFFLE_BITS>(tail & (size_ - 1));
return Base::template do_pop_any(states_[index], elements_[index]);
return Base::do_pop_any(states_[index], elements_[index]);
}

template<class U>
void do_push(U&& element, unsigned head) noexcept {
unsigned index = details::remap_index<SHUFFLE_BITS>(head & (size_ - 1));
Base::template do_push_any(std::forward<U>(element), states_[index], elements_[index]);
Base::do_push_any(std::forward<U>(element), states_[index], elements_[index]);
}

template<class U>
Expand Down

0 comments on commit eaf3037

Please sign in to comment.