Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: interstitial handling improvements #19

Merged
merged 3 commits into from
Sep 4, 2024
Merged

Conversation

mccutchen
Copy link
Owner

@mccutchen mccutchen commented Jan 5, 2023

Better handling of Bloomberg bot interstitial (fixes #18), plus better tracking of intermediate URLs when we hit interstitial special cases.


Outdated original description

A handful of tweaks and improvements here, but most importantly:

  • Special handling of Sailthru tracking links
  • Detect Bloomberg bot interstitial (fixes bloomberg.com bot detection #18)
  • Try new fake User-Agent to simulate iOS link preview machinery

@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2023

Codecov Report

Merging #19 (9c51471) into main (c0cda57) will increase coverage by 1.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
+ Coverage   98.04%   99.07%   +1.02%     
==========================================
  Files           6        7       +1     
  Lines         205      216      +11     
==========================================
+ Hits          201      214      +13     
+ Misses          2        1       -1     
+ Partials        2        1       -1     
Impacted Files Coverage Δ
canonicalizer.go 100.00% <ø> (ø)
tweet_fetcher.go 100.00% <ø> (ø)
sailthru_resolver.go 100.00% <100.00%> (ø)
urlresolver.go 97.64% <100.00%> (+2.46%) ⬆️

@mccutchen mccutchen changed the title Misc improvements (Sailthru tracking, Bloomberg interstitial, better fake User-Agent) feat: interstitial handling improvements Sep 4, 2024
@mccutchen mccutchen merged commit 63fd0e5 into main Sep 4, 2024
5 checks passed
@mccutchen mccutchen deleted the sailthru-bloomberg branch September 4, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bloomberg.com bot detection
2 participants