Skip to content

Commit

Permalink
fix(flaws): shared assets images must no be flaws (#12133)
Browse files Browse the repository at this point in the history
  • Loading branch information
fiji-flo authored Nov 15, 2024
1 parent cff300f commit b3013f9
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion build/check-images.ts
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,10 @@ export function checkImageReferences(
// might be something like `screenshot.png` for the sake of rendering
// it now, we still want the full relative URL.
img.attr("src", absoluteURL.pathname);
} else {
} else if (
absoluteURL.hostname !== "mdn.github.io" ||
!absoluteURL.pathname.startsWith("/shared-assets/")
) {
addImageFlaw(img, src, {
explanation: "External image URL",
externalImage: true,
Expand Down

0 comments on commit b3013f9

Please sign in to comment.