fix(macros/Non-standard_Header): update description #11163
+11
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ruth John <Rumyra@users.noreply.github.com>
dipikabh
reviewed
May 30, 2024
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
caugner
commented
Jun 6, 2024
|
@dipikabh Applied your suggestion, and updated the other translations (using GPT-4o). |
yin1999
reviewed
Jun 9, 2024
Co-authored-by: A1lo <yin199909@aliyun.com>
github-actions
bot
added
the
merge conflicts 🚧
|
This pull request has merge conflicts that must be resolved before it can be merged. |
JasonLamv-t
approved these changes
Nov 12, 2024
github-actions
bot
removed
the
merge conflicts 🚧
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #9774.
Problem
The non-standard disclaimer discourages from using the feature in production, although it might make sense in some instances.
Solution
Update the disclaimer to Ruth's suggestion.
Screenshots
Before
After
How did you test this change?
Ran
yarn devand opened http://localhost:3000/en-US/docs/Web/API/Element/gesturestart_event locally.