Removed redirecting all links to Facebook #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue description
Currently when clicking links in Messenger every link goes through Facebook. In case, when in a browser we are not logged in to Facebook it leads to a situation, where instead of the requested page we get a message that we are leaving Facebook. It's annoying, because it forces user to do another click. The same situation is while copying a link.
How the problem was approached
Generally, Messenger keeps with each link data attribute data-lynx-uri where it keeps URL to redirection page. It swaps href to data-lynx-uri when user hovers over the link. It doesn't check the contents of data-lynx-url, so we can safely input there our href, to keep link as we want it.